This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: add 100px marign right for branching nodes (SwitchConditon, IfCondition)#5693
Merged
boydc2014 merged 6 commits intomicrosoft:mainfrom Feb 9, 2021
Merged
fix: add 100px marign right for branching nodes (SwitchConditon, IfCondition)#5693boydc2014 merged 6 commits intomicrosoft:mainfrom
boydc2014 merged 6 commits intomicrosoft:mainfrom
Conversation
yeze322
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
8 tasks
boydc2014
previously approved these changes
Feb 8, 2021
Contributor
|
@yeze322 UT for boundary test seems to be failed FAIL adaptive-form packages/adaptive-flow/tests/adaptive-flow-renderer/layouters/calculateNodeBoundary.test.ts |
boydc2014
approved these changes
Feb 9, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…ndition) (microsoft#5693) * add 100px marign right for branching nodes * fix UT * UT: switch node size Co-authored-by: Lu Han <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #5637
With an extra 100px margin, the last case label of a SwitchConditon can be visible by scrolling right.
Task Item
Screenshots